From 03f17ac2f18ba7fc0a49d82ab9c4b4c49fe538a8 Mon Sep 17 00:00:00 2001
From: ntr <ntr@smokestack.io>
Date: Thu, 11 Apr 2024 18:07:27 +1000
Subject: [PATCH] gnerator

---
 .gitignore     |  1 +
 src/scraper.ts | 87 +++++++++++++++++++++++++-------------------------
 2 files changed, 45 insertions(+), 43 deletions(-)

diff --git a/.gitignore b/.gitignore
index d20a8c7..9774971 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,6 +2,7 @@
 
 .venv/
 gimmeme-d052de2b9472.json
+gimmeme-db7225b3cf31.json
 __pycache__/
 
 node_modules
diff --git a/src/scraper.ts b/src/scraper.ts
index 7d5b46f..3f408e5 100644
--- a/src/scraper.ts
+++ b/src/scraper.ts
@@ -1,6 +1,7 @@
 import axios from 'axios'
 
 import minBy from 'lodash/minBy'
+import maxBy from 'lodash/maxBy'
 
 import type { PrismaClient, Attachment } from '@prisma/client';
 import type { ImageAnnotatorClient } from '@google-cloud/vision';
@@ -130,6 +131,43 @@ export default function scraper(discordAuth, vision: ImageAnnotatorClient, minio
         }
     }
 
+    async function* fetchNew(channelId, log, latestMessageId) {
+        const messages = await fetchChannelMessagesAfter(channelId, latestMessageId)
+        if (messages.length === 0) {
+            log.info('no new messages')
+            return
+        }
+
+        log.info({ messages: messages.length, latestMessageId }, 'fetched new messages')
+        for (const msg of messages) {
+            yield msg
+        }
+        // not sure what order these are in
+        // or if guaranteed
+        const cursor = maxBy(messages, 'id').id
+        yield* fetchNew(channelId, log, cursor)
+    }
+
+    async function* fetchOld(channelId, log, earliestMessageId) {
+        let cursor = earliestMessageId
+
+        while (true) {
+            const messages = await fetchChannelMessagesBefore(channelId, cursor)
+            if (messages.length === 0) {
+                log.info('reached beginning of channel')
+                return
+            }
+
+            log.info({ messages: messages.length, cursor }, 'fetched older messages')
+            for (const msg of messages) {
+                yield msg
+            }
+            // not sure what order these are in
+            // or if guaranteed
+            cursor = minBy(messages, 'id').id
+        }
+    }
+
     async function getChannelHistory(channelId) {
         const channel = await fetchChannel(channelId)
         const guild = await fetchGuildDetails(channel.guild_id)
@@ -145,53 +183,16 @@ export default function scraper(discordAuth, vision: ImageAnnotatorClient, minio
             })
         }
 
-        async function fetchNew() {
-            const history = await ensureHistory()
-            const messages = await fetchChannelMessagesAfter(channelId, history.latestMessageId)
-            if (messages.length === 0) return
+        const history = await ensureHistory()
+        history.latestMessageId = 1227182587177340938n
 
-            const result = {
-                ...history,
-                messages: messages.length,
-            }
-
-            const newLatestMessageId = messages.map(m => m.id)
-            log.info(newLatestMessageId)
+        for await (const msg of fetchNew(channelId, log, history.latestMessageId)) {
+            log.info({ msg: 'new message', id: msg.id})
         }
 
-        async function fetchOld() {
-            const history = await ensureHistory()
-            const messages = await fetchChannelMessagesBefore(channelId, history.earliestMessageId)
-            if (messages.length === 0) return
-
-            const result = {
-                ...history,
-                messages: messages.length,
-            }
-
-            const earliestMessageId = minBy(messages, 'id').id
-            const attachments = await filterAttachments(log, messages, guild, channel);
-
-            log.info({
-                earliestMessageId,
-                messages: messages.length,
-                attachments: attachments.length,
-            })
-        }
-
-        await fetchNew()
-        await fetchOld()
-
-        // process them
-
-        // const messages = await fetchChannelMessagesBefore(channelId, history.earliestMessageId);
-
-        // const result = {
-        //     ...history,
-        //     newMessages: newMessages.length,
-        //     messages: messages.length,
+        // for await (const msg of fetchOld(channelId, log, history.earliestMessageId)) {
+        //     // log.info({ msg: 'new message', id: msg.id})
         // }
-        // get messages before earliestMessageId until there are 0
     }
 
     return {